Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed compatibility with Lumen 8.x without sessions #106

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

gabrielslau
Copy link

Description of the change

this fix was originally proposed on issue #83 and PR #84 and #90 without further interaction/response from the original contributor.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #83, #84 and #90

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

this fix was originally proposed on issue rollbar#83 and PR rollbar#84 and rollbar#90 without further interaction/response from the original contributor.
@bxsx bxsx linked an issue Nov 2, 2021 that may be closed by this pull request
@bxsx bxsx closed this Nov 2, 2021
@bxsx bxsx reopened this Nov 2, 2021
@bxsx bxsx closed this Nov 2, 2021
@bxsx bxsx reopened this Nov 2, 2021
@bxsx
Copy link

bxsx commented Nov 2, 2021

Hi @gabrielslau and thanks for bringing it up.

I've updated the conditional expression to use isset().

@bxsx bxsx self-assigned this Nov 2, 2021
@bxsx bxsx self-requested a review November 2, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lumen has no session support anymore and that breaks the handler
3 participants