Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include sessions data when sessions are available #84

Closed
wants to merge 1 commit into from
Closed

Only include sessions data when sessions are available #84

wants to merge 1 commit into from

Conversation

erwineverts
Copy link

No description provided.

@neochief
Copy link

neochief commented Jul 1, 2019

+1

@waltjones
Copy link

@erwineverts Thank you for the PR. The fix looks fine. Can you take a look at the failing test?

@waltjones
Copy link

Maybe all it needs is rebase master.

@tristanjahier
Copy link

OK this seems to be the same as #90.
It would fix the integration with Laravel Zero as well.

@darkcarnage
Copy link

Any plans to merge this PR ? That obviously solves the problem with Lumen.

Copy link

@villaflor villaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. It is make sense that checking the session if set first before getting all the session in case that the application is Laravel Lumen.

@tristanjahier
Copy link

@waltjones Any chance that this is accepted and merged?

gabrielslau added a commit to gabrielslau/rollbar-php-laravel that referenced this pull request Nov 16, 2020
this fix was originally proposed on issue rollbar#83 and PR rollbar#84 and rollbar#90 without further interaction/response from the original contributor.
@bxsx bxsx linked an issue Nov 2, 2021 that may be closed by this pull request
@bxsx
Copy link

bxsx commented Nov 2, 2021

Hey @erwineverts @neochief @darkcarnage @villaflor @tristanjahier

Seems that the branch is no longer available but I just merged #106 which duplicates this PR.

@bxsx bxsx self-assigned this Nov 2, 2021
@erwineverts
Copy link
Author

@bxsx Thank you! I've been using Sentry for the past couple of years. But great to see progress on this bug.

@bxsx
Copy link

bxsx commented Nov 3, 2021

Thanks @erwineverts
You can look at Rollbar again when you find spare time. There have been many enhancements and new features in recent years that may interest you.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lumen has no session support anymore and that breaks the handler
7 participants