Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove is_js dependency #1121

Merged
merged 1 commit into from
Sep 13, 2023
Merged

fix: remove is_js dependency #1121

merged 1 commit into from
Sep 13, 2023

Conversation

jplaisted
Copy link
Contributor

@jplaisted jplaisted commented Sep 12, 2023

Description of the change

#1111 bumped request-ip in an attempt to resolve a security vulnerability in one of its packagess (is_js). request-ip no longer depends on is_js, but it was not removed from this lock file. Not an npm expert, not sure why.

I ran the following command to remove is_js from the lock file (it is not specified in the package.json and is not transitively referenced; so it should not be in the lock file)

npm uninstall --lockfile-version 1 --save is_js

Proof it is not reachable:

➜  rollbar.js git:(master) npm ls is_js
rollbar@2.26.2 /Users/john.plaisted/workspace/rollbar.js
└── (empty)

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

#1111

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@jplaisted jplaisted marked this pull request as ready for review September 12, 2023 21:21
Copy link
Contributor

@waltjones waltjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jplaisted Thank you for the PR.

@waltjones waltjones merged commit ca540c9 into rollbar:master Sep 13, 2023
5 checks passed
@jplaisted jplaisted deleted the jp_is_js branch September 13, 2023 17:26
@farideliyev
Copy link

@waltjones, when do you plan release this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants