Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump request-ip to 3.3.0 in package-lock.json #1111

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

melvrickgoh
Copy link
Contributor

an extension of #1087, also bump the version of request-ip in package-lock.json

Description of the change

bump request-ip from 2.x to 3.3.0,
2. x version has a dependency is_js and it has a Vulnerability. I guess there are no > breaking changes between 2. x and 3. x
https://ossindex.sonatype.org/component/pkg:npm/is_js@0.9.0?utm_source=dependency-> check&utm_medium=integration&utm_content=7.4.3
For the past 6 years, there is no update for the is_js library.

Updating package-lock.json also avoids the CVE flags by Dependabot for dependency vulnerabilities

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • Maintenance

Related issues

Checklists

Development

  • Lint rules pass locally
  • All tests related to the changed code pass in development

@melvrickgoh
Copy link
Contributor Author

hi @waltjones, could you help take a look at this when free? (it's a continuation of #1087 )

@waltjones waltjones merged commit 6f83da1 into rollbar:master Aug 14, 2023
5 checks passed
@melvrickgoh melvrickgoh deleted the update/request-ip-dependency branch August 25, 2023 03:55
@jplaisted
Copy link
Contributor

FYI this still lists is_js in the lock file. It is no longer transitively reachable; but is still listed. It may need to be removed to"resolve" the vulnerability.

"is_js": {

@jplaisted jplaisted mentioned this pull request Sep 12, 2023
12 tasks
mudetroit pushed a commit that referenced this pull request Mar 14, 2024
Co-authored-by: Walt Jones <walt.jones@rollbar.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rollbar Vulnerability - CVE-2020-26302
3 participants