Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API support for deleting project access token #12

Closed
jmcvetta opened this issue Oct 6, 2020 · 3 comments
Closed

API support for deleting project access token #12

jmcvetta opened this issue Oct 6, 2020 · 3 comments
Assignees
Labels
API Support Support requests for the API team blocker Blocks significant ongoing work enhancement New feature or request

Comments

@jmcvetta
Copy link
Contributor

jmcvetta commented Oct 6, 2020

Currently the API does not support deleting a project access token. This functionality is required for the Terraform provider to manage project access tokens.

$ http DELETE https://api.rollbar.com/api/1/project/411334/access_token/d6d4b456f72048dfb8a933afe3ac66f6 X-Rollbar-Access-Token:redacted
HTTP/1.1 404 Not Found
Access-Control-Allow-Credentials: true
Access-Control-Allow-Origin: *
Alt-Svc: clear
Content-Length: 40
Content-Type: application/json; charset=utf-8
Date: Tue, 06 Oct 2020 11:48:58 GMT
Server: nginx/1.17.9
Via: 1.1 google
X-Response-Time: 1ms

{
    "err": 1,
    "message": "not found"
}
@jmcvetta jmcvetta added the enhancement New feature or request label Oct 6, 2020
@jmcvetta jmcvetta added this to the Access Tokens milestone Oct 6, 2020
@jmcvetta
Copy link
Contributor Author

jmcvetta commented Oct 6, 2020

@mrunalk @coryvirok

Is this a good place to open Issues for API feature requests / bugs / etc? Or is there another repo that would be better?

@coryvirok
Copy link
Contributor

This should work for now. I'll link to it in our internal tracking system.

@jmcvetta jmcvetta added the API Support Support requests for the API team label Oct 7, 2020
This was referenced Oct 12, 2020
@jmcvetta jmcvetta assigned jmcvetta and unassigned jmcvetta Oct 14, 2020
This was referenced Nov 10, 2020
@jmcvetta jmcvetta added the blocker Blocks significant ongoing work label Nov 18, 2020
@mrunalk
Copy link

mrunalk commented Nov 20, 2020

You should be able to delete project access token now. I haven't updated the API doc yet will do that soon.

@mrunalk mrunalk closed this as completed Nov 20, 2020
jmcvetta added a commit that referenced this issue Nov 24, 2020
Default tokens are now actually deleted (per #12) and thus are defunct
for use in tests.
jmcvetta added a commit that referenced this issue Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Support Support requests for the API team blocker Blocks significant ongoing work enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants