chore: update eval warning msg (#1221)

crates/rolldown/src/ast_scanner/impl_visit.rs

@@ -54,12 +54,8 @@ impl<'me, 'ast> Visit<'ast> for AstScanner<'me> {
         }
         if ident.name == "eval" {
           self.result.warnings.push(
-            BuildError::unsupported_eval(
-              self.file_path.to_string(),
-              Arc::clone(self.source),
-              ident.span,
-            )
-            .with_severity_warning(),
+            BuildError::eval(self.file_path.to_string(), Arc::clone(self.source), ident.span)
+              .with_severity_warning(),
           );
         }
       }

crates/rolldown/tests/fixtures/warnings/eval/artifacts.snap

@@ -1,14 +1,14 @@
 ---
 source: crates/rolldown/tests/common/case.rs
 expression: content
-input_file: crates/rolldown/tests/fixtures/warnings/basic
+input_file: crates/rolldown/tests/fixtures/warnings/eval
 ---
 # warnings
 
 ## EVAL
 
 ```text
-[EVAL] Warning: Rolldown does not support `eval` function currently.
+[EVAL] Warning: Use of eval is strongly discouraged as it poses security risks and may cause issues with minification.
    ╭─[main.js:1:13]
    │
  1 │ console.log(eval)

crates/rolldown_error/src/build_error/error_constructors.rs

@@ -9,11 +9,10 @@ use rolldown_resolver::ResolveError;
 use super::BuildError;
 
 use crate::events::{
-  circular_dependency::CircularDependency, external_entry::ExternalEntry,
+  circular_dependency::CircularDependency, eval::Eval, external_entry::ExternalEntry,
   forbid_const_assign::ForbidConstAssign, sourcemap_error::SourceMapError,
   unresolved_entry::UnresolvedEntry, unresolved_import::UnresolvedImport,
-  unresolved_import_treated_as_external::UnresolvedImportTreatedAsExternal,
-  unsupported_eval::UnsupportedEval, NapiError,
+  unresolved_import_treated_as_external::UnresolvedImportTreatedAsExternal, NapiError,
 };
 
 impl BuildError {
@@ -72,7 +71,7 @@ impl BuildError {
     Self::new_inner(NapiError { status, reason })
   }
 
-  pub fn unsupported_eval(filename: String, source: Arc<str>, span: Span) -> Self {
-    Self::new_inner(UnsupportedEval { filename, eval_span: span, source })
+  pub fn eval(filename: String, source: Arc<str>, span: Span) -> Self {
+    Self::new_inner(Eval { filename, span, source })
   }
 }

crates/rolldown_error/src/events/unsupported_eval.rs → crates/rolldown_error/src/events/eval.rs

@@ -7,35 +7,35 @@ use crate::{diagnostic::Diagnostic, types::diagnostic_options::DiagnosticOptions
 use super::BuildEvent;
 
 #[derive(Debug)]
-pub struct UnsupportedEval {
+pub struct Eval {
   pub filename: String,
   pub source: Arc<str>,
-  pub eval_span: Span,
+  pub span: Span,
 }
 
-impl BuildEvent for UnsupportedEval {
+impl BuildEvent for Eval {
   fn kind(&self) -> crate::event_kind::EventKind {
     crate::event_kind::EventKind::Eval
   }
 
   fn code(&self) -> &'static str {
-    "UNSUPPORTED_EVAL"
+    "EVAL"
   }
 
   fn message(&self, _opts: &DiagnosticOptions) -> String {
-    format!("Unsupported eval at {}", self.filename)
+    format!("Use of eval in '{}' is strongly discouraged as it poses security risks and may cause issues with minification.", self.filename)
   }
 
   fn on_diagnostic(&self, diagnostic: &mut Diagnostic, opts: &DiagnosticOptions) {
     let filename = opts.stabilize_path(&self.filename);
 
-    diagnostic.title = "Rolldown does not support `eval` function currently.".to_string();
+    diagnostic.title = "Use of eval is strongly discouraged as it poses security risks and may cause issues with minification.".to_string();
 
     let file_id = diagnostic.add_file(filename, Arc::clone(&self.source));
 
     diagnostic.add_label(
       &file_id,
-      self.eval_span.start..self.eval_span.end,
+      self.span.start..self.span.end,
       "Used `eval` function here.".to_string(),
     );
   }

crates/rolldown_error/src/events/mod.rs

@@ -5,13 +5,13 @@ use crate::{
 };
 
 pub mod circular_dependency;
+pub mod eval;
 pub mod external_entry;
 pub mod forbid_const_assign;
 pub mod sourcemap_error;
 pub mod unresolved_entry;
 pub mod unresolved_import;
 pub mod unresolved_import_treated_as_external;
-pub mod unsupported_eval;
 
 pub trait BuildEvent: Debug + Sync + Send {
   fn kind(&self) -> EventKind;