feat: support enabling tracing #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Nov 16, 2023
Merged
hyf0
force-pushed
the
11-16-feat_support_to_enable_tracing
branch
from
6601e88
to
4bd31ca
Compare
This was referenced Nov 17, 2023
hyf0
force-pushed
the
11-16-feat_support_to_enable_tracing
branch
from
4bd31ca
to
bad653e
Compare
hyf0
force-pushed
the
11-16-feat_support_to_enable_tracing
branch
from
bad653e
to
009fd01
Compare
houyunlu
approved these changes
Nov 17, 2023
milesj
reviewed
Nov 17, 2023
| .with_default_directive(LevelFilter::TRACE.into()) | ||
| .from_env_lossy(), | ||
| ) | ||
| .with(fmt::layer().pretty().without_time()) |
There was a problem hiding this comment.
looks like both of these functions are basically the same except this line. can they be shared somehow?
There was a problem hiding this comment.
Yeah. I tried before. It's a little difficult due to generics. Every call of .with return a new type, I have to use macros to shared the logic. I don't prefer(unless I have to) to write the macros now and it may have better solutions, so I just leave it what it is now :).
There was a problem hiding this comment.
Ah yeah that makes sense. kind of hate the builder pattern sometimes because of this.
hyf0
force-pushed
the
11-16-feat_support_to_enable_tracing
branch
from
009fd01
to
05b89f0
Compare
milesj
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/rolldown-rs/rolldown/blob/6601e8863d8934f18f7b1aa9b44867aba854b6f4/crates/rolldown_tracing/src/lib.rs#L1-L6
Test Plan