-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: bump string_wizard
for better performance
#292
Merged
hyf0
merged 2 commits into
main
from
11-16-perf_bump_string_wizard_for_better_performance
Nov 17, 2023
Merged
perf: bump string_wizard
for better performance
#292
hyf0
merged 2 commits into
main
from
11-16-perf_bump_string_wizard_for_better_performance
Nov 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
hyf0
force-pushed
the
11-16-perf_bump_string_wizard_for_better_performance
branch
from
November 16, 2023 14:57
3366981
to
079c922
Compare
This was referenced Nov 16, 2023
Merged
milesj
approved these changes
Nov 16, 2023
hyf0
force-pushed
the
11-16-feat_support_to_enable_tracing
branch
from
November 17, 2023 03:21
6601e88
to
4bd31ca
Compare
hyf0
force-pushed
the
11-16-perf_bump_string_wizard_for_better_performance
branch
from
November 17, 2023 03:21
ad93546
to
f219c1d
Compare
This was referenced Nov 17, 2023
hyf0
force-pushed
the
11-16-feat_support_to_enable_tracing
branch
from
November 17, 2023 04:46
4bd31ca
to
bad653e
Compare
hyf0
force-pushed
the
11-16-perf_bump_string_wizard_for_better_performance
branch
from
November 17, 2023 04:46
f219c1d
to
59cb64f
Compare
hyf0
force-pushed
the
11-16-feat_support_to_enable_tracing
branch
from
November 17, 2023 05:00
bad653e
to
009fd01
Compare
hyf0
force-pushed
the
11-16-perf_bump_string_wizard_for_better_performance
branch
from
November 17, 2023 05:00
59cb64f
to
8d8424a
Compare
hyf0
force-pushed
the
11-16-feat_support_to_enable_tracing
branch
from
November 17, 2023 05:19
009fd01
to
05b89f0
Compare
hyf0
force-pushed
the
11-16-perf_bump_string_wizard_for_better_performance
branch
from
November 17, 2023 05:19
8d8424a
to
10527dd
Compare
Base automatically changed from
11-16-feat_support_to_enable_tracing
to
main
November 17, 2023 05:38
hyf0
force-pushed
the
11-16-perf_bump_string_wizard_for_better_performance
branch
from
November 17, 2023 05:38
10527dd
to
a184843
Compare
hyf0
deleted the
11-16-perf_bump_string_wizard_for_better_performance
branch
November 17, 2023 05:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rolldown/string_wizard#9
The problem is that bundling cjs module requre calling
MagicString#indent
, which was incredibly slow due to lacking of optimization: rolldown/string_wizard@4515818.Test Plan