This repository has been archived by the owner on Jan 16, 2018. It is now read-only.
Use FQCN instead of type-name for column-types #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -81,7 +81,7 @@ public function __construct(ColumnInterface $column, DatagridViewInterface $data | |||
| $this->column = $column; | |||
| $this->datagrid = $datagrid; | |||
|
|
|||
| $this->type = $column->getType()->getName(); | |||
| $this->type = get_class($column->getType()); | |||
There was a problem hiding this comment.
We actually don't need the type anymore, just the block prefix.
sstok
added a commit
that referenced
this pull request
Dec 24, 2015
This PR was merged into the master branch. Discussion ---------- |Q |A | |--- |---| |Bug Fix? |no | |New Feature? |yes| |BC Breaks? |yes| |Deprecations?|no | |Fixed Tickets| | Use FQCN instead of type-name for column-types (as done in Symfony 3). This simplifies the internal logic and makes the system slightly faster. Commits ------- 1840188 Use FQCN instead of type-name for column-types
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use FQCN instead of type-name for column-types (as done in Symfony 3).
This simplifies the internal logic and makes the system slightly faster.