feat(update.sh): [Don’t update kernel if kernel version is already installed] #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change should make it so that you will not need to install the kernal each update
|
Will review when I'm free. Until then I've assigned @wizard-28 to review. |
ajstrongdev
requested changes
May 6, 2022
…talled This change should make it so that you will not need to install the kernel each update
ajstrongdev
approved these changes
May 6, 2022
wizard-28
reviewed
May 7, 2022
update.sh
Outdated
| The upgrade has been completed. Please reboot your system to see the changes.---" |
There was a problem hiding this comment.
I am unsure. I'll review it in further detail when I am home.
ajstrongdev
requested changes
May 10, 2022
update.sh
Outdated
| The upgrade has been completed. Please reboot your system to see the changes.---" |
There was a problem hiding this comment.
This needs to be fixed. It should be:
echo "---
The upgrade has been completed. Please reboot your system to see the changes
---"Fixed message display bug that tells the user to reboot the system
ajstrongdev
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it so that when the update is called it will check for the existence of 5.17.5 in the config files as an identifier for the kernel and if this identifier is found the kernel will not be installed due to it being installed already