Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update dependency graph #1635

Merged
merged 3 commits into from
May 7, 2024
Merged

docs: Update dependency graph #1635

merged 3 commits into from
May 7, 2024

Conversation

nashqueue
Copy link
Member

Overview

This PR aims to be a starting point for a dependency graph update

The update is adding:

  • more IBC work
  • connecting Sequencing API and adding Execution
  • updates to overall progress

Copy link
Contributor

coderabbitai bot commented Apr 22, 2024

Important

Auto Review Skipped

Review was skipped due to path filters

Files ignored due to path filters (1)
  • specs/src/specs/dependency-graph.drawio.svg is excluded by !**/*.svg

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Apr 22, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://rollkit.github.io/rollkit/pr-preview/pr-1635/
on branch gh-pages at 2024-05-07 19:42 UTC

@nashqueue nashqueue changed the title update graph (docs): Update dependeny graph Apr 22, 2024
Copy link
Member

@tzdybal tzdybal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you worked with not-the-latest version of the file while updating.

specs/src/specs/dependency-graph.drawio.svg Outdated Show resolved Hide resolved
specs/src/specs/dependency-graph.drawio.svg Outdated Show resolved Hide resolved
specs/src/specs/dependency-graph.drawio.svg Outdated Show resolved Hide resolved
specs/src/specs/dependency-graph.drawio.svg Outdated Show resolved Hide resolved
specs/src/specs/dependency-graph.drawio.svg Outdated Show resolved Hide resolved
specs/src/specs/dependency-graph.drawio.svg Outdated Show resolved Hide resolved
specs/src/specs/dependency-graph.drawio.svg Outdated Show resolved Hide resolved
specs/src/specs/dependency-graph.drawio.svg Outdated Show resolved Hide resolved
specs/src/specs/dependency-graph.drawio.svg Outdated Show resolved Hide resolved
specs/src/specs/dependency-graph.drawio.svg Outdated Show resolved Hide resolved
Copy link
Member

@tzdybal tzdybal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avail-da points to credible neutrality and at the same time credible neutrality points to Other DA implementations. I think 'other DA implementations` might be removed from the graph.

Copy link
Member

@tzdybal tzdybal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could introduce a color for "outcomes" that we're enabling, but not necessarily intend to build (like explorers, prover market, execution market, sequencer API implementations, etc)

@Manav-Aggarwal Manav-Aggarwal changed the title (docs): Update dependeny graph (docs): Update dependency graph Apr 29, 2024
MSevey
MSevey previously requested changes Apr 30, 2024
Copy link
Contributor

@MSevey MSevey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending Tomasz comments

@Manav-Aggarwal Manav-Aggarwal changed the title (docs): Update dependency graph docs: Update dependency graph May 7, 2024
Manav-Aggarwal
Manav-Aggarwal previously approved these changes May 7, 2024
tuxcanfly
tuxcanfly previously approved these changes May 7, 2024
Copy link
Member

@tzdybal tzdybal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last P2P Rollmint Headersync to fix.

@Manav-Aggarwal Manav-Aggarwal dismissed stale reviews from tuxcanfly and themself via 64e24a9 May 7, 2024 19:42
Copy link
Member

@tzdybal tzdybal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MSevey MSevey added this pull request to the merge queue May 7, 2024
Merged via the queue into main with commit 45b1573 May 7, 2024
23 checks passed
@MSevey MSevey deleted the graph-update branch May 7, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants