fix(dynamic-import-vars): allow ./${var}.suffix.js

[lennyburdette]

Rollup Plugin Name: dynamic-import-vars

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

Allow dynamically importing files in the same directory with an extra suffix before the extension.

My motivating example is trying to import a library generated with Stencil. It generates a dynamic import that looks like this:

return import(
    /* webpackInclude: /\.entry\.js$/ */
    /* webpackExclude: /\.system\.entry\.js$/ */
    /* webpackMode: "lazy" */
    `./${bundleId}.entry.js${ ''}`)

My interpretation of the README suggests this should be possible. I changed the assertion for "Imports to your own directory must specify a filename pattern" to a stricter regex. I'm happy to change the implementation if regexes aren't desired.

Thanks!

[LarsDenBakker]

This effectively disables the check. I think it's better to add an option which allows these kinds of imports, although they're quite dangerous because the glob will match your current file as well.

[lennyburdette]

My assumption was that if ./mod-${id}.js was allowed, then ./${id}.mod.js should also be allowed — both technically allow matching the current file if it's named "mod-current.js" or "current.mod.js".

But! For my specific use-case I discovered that Stencil provides a tree-shakable, non-lazy-loading build, so I'm unblocked. Feel free to close or amend this however you like. Thanks for the review!

[LarsDenBakker]

Ah I see, do we allow ./mod-${id}.js currently? I guess that makes sense then.

[lennyburdette]

yep!

// not allowed
import(`./${foo}.js`);
// allowed
import(`./module-${foo}.js`);

what's tripping me up is that the Stencil file output is is component-name.entry.js — using a period makes the current startsWith think that a file extension is next, not a module name suffix.

[shellscape]

@LarsDenBakker @danielgindi @tjenkinson gentle ping for review

[shellscape]

@LarsDenBakker @danielgindi @tjenkinson another gentle ping. I'm inclined to move this one forward.

[danielgindi]

Looks good to me and makes sense.

[LarsDenBakker]

LGTM as well. sorry haven't been spending a lot of time on open source lately

[lennyburdette]

Thank you!