Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

Fix duplicate export error (e.g. when importing Cheerio) #230

Merged
merged 1 commit into from Oct 7, 2017

Conversation

caleb531
Copy link
Contributor

Fixes rollup/rollup#1637

I've tried to follow @kzc's patch and test cases as closely as I could, but please let me know if I need to make any changes.

Thanks,
Caleb

@lukastaegert
Copy link
Member

Looks great, sorry to have kept you waiting 🎉

@lukastaegert lukastaegert merged commit 77c4838 into rollup:master Oct 7, 2017
@caleb531
Copy link
Contributor Author

caleb531 commented Oct 7, 2017

@lukastaegert Great, thank you! When could I expect the next release of rollup-plugin-commonjs?

@caleb531 caleb531 deleted the duplicate-export-fix branch October 7, 2017 19:32
@lukastaegert
Copy link
Member

Give me a few more minutes 😀

@lukastaegert
Copy link
Member

Oh no, maybe I overestimated my powers here which only seem to extend to merging PRs put not to publishing new versions. I will PM @Rich-Harris as he will probably need to do this.

@lukastaegert
Copy link
Member

Until @Rich-Harris is back at the internet to publish a new version, you can install a version containing this fix via

npm install github:rollup-plugin-commonjs@rollup/rollup-plugin-commonjs#bundled-v8.2.3

which should contain all necessary build artefacts.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using Cheerio with Rollup: Duplicate export 'default'
2 participants