Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

Fix duplicate export error (e.g. when importing Cheerio) #230

Merged
merged 1 commit into from
Oct 7, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/transform.js
Original file line number Diff line number Diff line change
Expand Up @@ -374,10 +374,12 @@ export default function transformCommonjs ( code, id, isEntry, ignoreGlobal, ign
`export { ${name} };` :
`export { ${deconflicted} as ${name} };`;

namedExportDeclarations.push({
str: declaration,
name
});
if ( name !== 'default' ) {
namedExportDeclarations.push({
str: declaration,
name
});
}

defaultExportPropertyAssignments.push( `${moduleName}.${name} = ${deconflicted};` );
}
Expand Down
6 changes: 6 additions & 0 deletions test/function/duplicate-default-exports-c/exports.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
exports.Foo = 1;
exports.var = 'VAR';
exports.default = {
Foo: 2,
default: 3
};
11 changes: 11 additions & 0 deletions test/function/duplicate-default-exports-c/main.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import E from './exports.js';
import { Foo } from './exports.js';
import { var as Var } from './exports.js';

assert.strictEqual( E.Foo, 1 );
assert.strictEqual( E.var, 'VAR' );
assert.deepEqual( E.default, { Foo: 2, default: 3 });
assert.strictEqual( E.default.Foo, 2 );
assert.strictEqual( E.default.default, 3 );
assert.strictEqual( Foo, 1 );
assert.strictEqual( Var, 'VAR' );