fix(browser-resolve): fix regressions from refactor

rollup · Jan 15, 2018 · 7529f70 · 7529f70
1 parent 1b26066
commit 7529f70
Show file tree

Hide file tree

Showing 20 changed files with 120 additions and 9 deletions.
diff --git a/src/index.js b/src/index.js
@@ -37,13 +37,14 @@ export default function nodeResolve ( options = {} ) {
 			if ( !importer ) return null;
 
 			if (options.browser && browserMapCache[importer]) {
+				const resolvedImportee = resolve( dirname( importer ), importee );
 				const browser = browserMapCache[importer];
-				if (browser[importee]) {
-					importee = browser[importee];
-				}
-				if (browser[importee] === false) {
+				if (browser[importee] === false || browser[resolvedImportee] === false) {
 					return ES6_BROWSER_EMPTY;
 				}
+				if (browser[importee] || browser[resolvedImportee] || browser[resolvedImportee + '.js'] || browser[resolvedImportee + '.json']) {
+					importee = browser[importee] || browser[resolvedImportee] || browser[resolvedImportee + '.js'] || browser[resolvedImportee + '.json'];
+				}
 			}
 
 
@@ -66,19 +67,26 @@ export default function nodeResolve ( options = {} ) {
 					importee,
 					Object.assign({
 						basedir: dirname( importer ),
-						packageFilter ( pkg ) {
+						packageFilter ( pkg, pkgPath ) {
+							const pkgRoot = dirname( pkgPath );
 							if (options.browser && typeof pkg[ 'browser' ] === 'object') {
 								packageBrowserField = Object.keys(pkg[ 'browser' ]).reduce((browser, key) => {
-									browser[ key ] = pkg[ 'browser' ][key];
-									if (key[0] === '.' && !extname(key)) browser[ key + '.js'] = browser[ key + '.json' ] = browser[ key ];
+									const resolved = pkg[ 'browser' ][ key ] === false ? false : resolve( pkgRoot, pkg[ 'browser' ][ key ] );
+									browser[ key ] = resolved;
+									if ( key[0] === '.' ) {
+										const absoluteKey = resolve( pkgRoot, key );
+										browser[ absoluteKey ] = resolved;
+										if (!extname(key)) browser[ absoluteKey + '.js'] = browser[ absoluteKey+ '.json' ] = browser[ key ];
+									}
 									return browser;
 								}, {});
 							}
 
+							const absoluteMain = pkg[ 'main' ] ? resolve( pkgRoot, pkg[ 'main' ] ) : false;
 							if (options.browser && typeof pkg[ 'browser' ] === 'string') {
 								pkg[ 'main' ] = pkg[ 'browser' ];
-							} else if (options.browser && typeof pkg[ 'browser' ] === 'object' && pkg[ 'browser' ][ pkg[ 'main' ] ]) {
-								pkg[ 'main' ] = pkg[ 'browser' ][ pkg[ 'main' ] ];
+							} else if (options.browser && packageBrowserField && (packageBrowserField[ pkg[ 'main' ] ] || packageBrowserField[ absoluteMain ])) {
+								pkg[ 'main' ] = packageBrowserField[ pkg[ 'main' ] ] || packageBrowserField[ absoluteMain ];
 							} else if ( useModule && pkg[ 'module' ] ) {
 								pkg[ 'main' ] = pkg[ 'module' ];
 							} else if ( useJsnext && pkg[ 'jsnext:main' ] ) {

diff --git a/test/node_modules/builtins-browser/fs.js b/test/node_modules/builtins-browser/fs.js
diff --git a/test/node_modules/builtins-browser/index.js b/test/node_modules/builtins-browser/index.js
diff --git a/test/node_modules/builtins-browser/package.json b/test/node_modules/builtins-browser/package.json
diff --git a/test/node_modules/isomorphic-nested/lib/browser-dep.js b/test/node_modules/isomorphic-nested/lib/browser-dep.js
diff --git a/test/node_modules/isomorphic-nested/lib/browser-test.js b/test/node_modules/isomorphic-nested/lib/browser-test.js
diff --git a/test/node_modules/isomorphic-nested/lib/browser.js b/test/node_modules/isomorphic-nested/lib/browser.js
diff --git a/test/node_modules/isomorphic-nested/lib/dep.js b/test/node_modules/isomorphic-nested/lib/dep.js
diff --git a/test/node_modules/isomorphic-nested/lib/index.js b/test/node_modules/isomorphic-nested/lib/index.js
diff --git a/test/node_modules/isomorphic-nested/package.json b/test/node_modules/isomorphic-nested/package.json
diff --git a/test/node_modules/isomorphic-object-main/browser-dep.js b/test/node_modules/isomorphic-object-main/browser-dep.js
diff --git a/test/node_modules/isomorphic-object-main/browser-test.js b/test/node_modules/isomorphic-object-main/browser-test.js
diff --git a/test/node_modules/isomorphic-object-main/browser.js b/test/node_modules/isomorphic-object-main/browser.js
diff --git a/test/node_modules/isomorphic-object-main/dep.js b/test/node_modules/isomorphic-object-main/dep.js
diff --git a/test/node_modules/isomorphic-object-main/index.js b/test/node_modules/isomorphic-object-main/index.js
diff --git a/test/node_modules/isomorphic-object-main/package.json b/test/node_modules/isomorphic-object-main/package.json
diff --git a/test/samples/browser-object-builtin/main.js b/test/samples/browser-object-builtin/main.js
@@ -0,0 +1,2 @@
+import main from 'builtins-browser';
+export default main;
diff --git a/test/samples/browser-object-main/main.js b/test/samples/browser-object-main/main.js
@@ -0,0 +1,2 @@
+import { env, dep, test } from 'isomorphic-object-main';
+export { env, dep, test };
diff --git a/test/samples/browser-object-nested/main.js b/test/samples/browser-object-nested/main.js
@@ -0,0 +1,2 @@
+import { env, dep, test } from 'isomorphic-nested';
+export { env, dep, test };
diff --git a/test/test.js b/test/test.js
@@ -155,6 +155,52 @@ describe( 'rollup-plugin-node-resolve', function () {
 		});
 	});
 
+	it( 'allows use of object browser field, resolving `main`', function () {
+		return rollup.rollup({
+			entry: 'samples/browser-object-main/main.js',
+			plugins: [
+				nodeResolve({
+					main: true,
+					browser: true
+				})
+			]
+		}).then( executeBundle ).then( module => {
+			assert.equal( module.exports.env, 'browser' );
+			assert.equal( module.exports.dep, 'browser-dep' );
+			assert.equal( module.exports.test, 43 );
+		});
+	});
+
+	it( 'allows use of object browser field, resolving replaced builtins', function () {
+		return rollup.rollup({
+			entry: 'samples/browser-object-builtin/main.js',
+			plugins: [
+				nodeResolve({
+					main: true,
+					browser: true
+				})
+			]
+		}).then( executeBundle ).then( module => {
+			assert.equal( module.exports, 'browser-fs' );
+		});
+	});
+
+	it( 'allows use of object browser field, resolving nested directories', function () {
+		return rollup.rollup({
+			entry: 'samples/browser-object-nested/main.js',
+			plugins: [
+				nodeResolve({
+					main: true,
+					browser: true
+				})
+			]
+		}).then( executeBundle ).then( module => {
+			assert.equal( module.exports.env, 'browser' );
+			assert.equal( module.exports.dep, 'browser-dep' );
+			assert.equal( module.exports.test, 43 );
+		});
+	});
+
 	it( 'supports `false` in browser field', function () {
 		return rollup.rollup({
 			entry: 'samples/browser-false/main.js',