Prevent unintended ASI for nested conditionals (#3732)

rollup · Aug 16, 2020 · 57ed7e3 · 57ed7e3
1 parent 4b432dc
commit 57ed7e3
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 4 deletions.
diff --git a/src/ast/nodes/ConditionalExpression.ts b/src/ast/nodes/ConditionalExpression.ts
@@ -187,6 +187,7 @@ export default class ConditionalExpression extends NodeBase implements Deoptimiz
 				isCalleeOfRenderedParent: renderedParentType
 					? isCalleeOfRenderedParent
 					: (this.parent as CallExpression).callee === this,
+				preventASI: true,
 				renderedParentType: renderedParentType || this.parent.type
 			});
 		} else {

diff --git a/src/ast/nodes/LogicalExpression.ts b/src/ast/nodes/LogicalExpression.ts
@@ -180,6 +180,7 @@ export default class LogicalExpression extends NodeBase implements Deoptimizable
 				isCalleeOfRenderedParent: renderedParentType
 					? isCalleeOfRenderedParent
 					: (this.parent as CallExpression).callee === this,
+				preventASI,
 				renderedParentType: renderedParentType || this.parent.type
 			});
 		} else {

diff --git a/src/ast/nodes/YieldExpression.ts b/src/ast/nodes/YieldExpression.ts
@@ -26,7 +26,7 @@ export default class YieldExpression extends NodeBase {
 
 	render(code: MagicString, options: RenderOptions) {
 		if (this.argument) {
-			this.argument.render(code, options);
+			this.argument.render(code, options, { preventASI: true });
 			if (this.argument.start === this.start + 5 /* 'yield'.length */) {
 				code.prependLeft(this.start + 5, ' ');
 			}

diff --git a/test/function/samples/prevent-tree-shaking-asi/main.js b/test/function/samples/prevent-tree-shaking-asi/main.js
@@ -2,7 +2,9 @@ function test1() {
 	return true ?
 		/* kept */
 
-		'expected' :
+		true ?
+			'expected' :
+			'unexpected' :
 		'unexpected';
 }
 assert.strictEqual(test1(), 'expected');
@@ -12,15 +14,17 @@ function test2() {
 		'unexpected' :
 		/* kept */
 
-		'expected';
+		false ?
+			'unexpected' :
+			'expected';
 }
 assert.strictEqual(test2(), 'expected');
 
 function test3() {
 	return true &&
 		/* kept */
 
-		'expected';
+		'expected'  || false;
 }
 assert.strictEqual(test3(), 'expected');
 
@@ -40,3 +44,9 @@ try {
 } catch (err) {
 	assert.strictEqual(err.message, 'expected');
 }
+
+function* test5() {
+	yield false ||
+	'expected'
+}
+assert.strictEqual(test5().next().value, 'expected');