safe hasOwnProperty call (#5010)

* safe hasOwnProperty call

* Create _config.js

* Create main.js

* Create mod.js

* Create external.js

* Update _config.js

* Update external.js

* Update main.js

* Update main.js

* Delete mod.js

* Update _config.js

* Update _config.js

* Update external.js

* Update _config.js

* Update _config.js

* update forms

* Update _config.js

* forms

* forms

* Update _config.js

docs/configuration-options/index.md

@@ -729,7 +729,7 @@ export * from 'external';
 var external = require('external');
 
 Object.keys(external).forEach(function (k) {
-	if (k !== 'default' && !exports.hasOwnProperty(k))
+	if (k !== 'default' && !Object.prototype.hasOwnProperty.call(exports, k))
 		Object.defineProperty(exports, k, {
 			enumerable: true,
 			get: function () {
@@ -742,7 +742,7 @@ Object.keys(external).forEach(function (k) {
 const external = require('external');
 
 for (const k in external) {
-	if (k !== 'default' && !exports.hasOwnProperty(k))
+	if (k !== 'default' && !Object.prototype.hasOwnProperty.call(exports, k))
 		Object.defineProperty(exports, k, {
 			enumerable: true,
 			get: () => external[k]

src/finalisers/shared/getExportBlock.ts

@@ -90,7 +90,7 @@ export function getExportBlock(
 			for (const specifier of reexports) {
 				if (specifier.reexported === '*') {
 					if (exportBlock) exportBlock += n;
-					const copyPropertyIfNecessary = `{${n}${t}if${_}(k${_}!==${_}'default'${_}&&${_}!exports.hasOwnProperty(k))${_}${getDefineProperty(
+					const copyPropertyIfNecessary = `{${n}${t}if${_}(k${_}!==${_}'default'${_}&&${_}!Object.prototype.hasOwnProperty.call(exports,${_}k))${_}${getDefineProperty(
 						name,
 						specifier.needsLiveBinding,
 						t,

test/chunking-form/samples/chunking-star-external/_expected/amd/main1.js

@@ -9,7 +9,7 @@ define(['exports', 'starexternal1', 'external1', './generated-dep', 'starexterna
 	exports.dep = dep.dep;
 	exports.main = main;
 	Object.keys(starexternal1).forEach(function (k) {
-		if (k !== 'default' && !exports.hasOwnProperty(k)) Object.defineProperty(exports, k, {
+		if (k !== 'default' && !Object.prototype.hasOwnProperty.call(exports, k)) Object.defineProperty(exports, k, {
 			enumerable: true,
 			get: function () { return starexternal1[k]; }
 		});

test/chunking-form/samples/chunking-star-external/_expected/amd/main2.js

@@ -9,7 +9,7 @@ define(['exports', './generated-dep', 'external2', 'starexternal2'], (function (
 	});
 	exports.main = main;
 	Object.keys(starexternal2).forEach(function (k) {
-		if (k !== 'default' && !exports.hasOwnProperty(k)) Object.defineProperty(exports, k, {
+		if (k !== 'default' && !Object.prototype.hasOwnProperty.call(exports, k)) Object.defineProperty(exports, k, {
 			enumerable: true,
 			get: function () { return starexternal2[k]; }
 		});

test/chunking-form/samples/chunking-star-external/_expected/cjs/main1.js

@@ -15,7 +15,7 @@ Object.defineProperty(exports, 'e', {
 exports.dep = dep.dep;
 exports.main = main;
 Object.keys(starexternal1).forEach(function (k) {
-	if (k !== 'default' && !exports.hasOwnProperty(k)) Object.defineProperty(exports, k, {
+	if (k !== 'default' && !Object.prototype.hasOwnProperty.call(exports, k)) Object.defineProperty(exports, k, {
 		enumerable: true,
 		get: function () { return starexternal1[k]; }
 	});

test/chunking-form/samples/chunking-star-external/_expected/cjs/main2.js

@@ -13,7 +13,7 @@ Object.defineProperty(exports, 'e', {
 });
 exports.main = main;
 Object.keys(starexternal2).forEach(function (k) {
-	if (k !== 'default' && !exports.hasOwnProperty(k)) Object.defineProperty(exports, k, {
+	if (k !== 'default' && !Object.prototype.hasOwnProperty.call(exports, k)) Object.defineProperty(exports, k, {
 		enumerable: true,
 		get: function () { return starexternal2[k]; }
 	});

test/form/samples/export-all-before-named/_expected/amd.js

@@ -6,7 +6,7 @@ define(['exports', 'external'], (function (exports, external) { 'use strict';
 
 	exports.internalFn = internalFn;
 	Object.keys(external).forEach(function (k) {
-		if (k !== 'default' && !exports.hasOwnProperty(k)) Object.defineProperty(exports, k, {
+		if (k !== 'default' && !Object.prototype.hasOwnProperty.call(exports, k)) Object.defineProperty(exports, k, {
 			enumerable: true,
 			get: function () { return external[k]; }
 		});

test/form/samples/export-all-before-named/_expected/cjs.js

@@ -8,7 +8,7 @@ function internalFn(path) {
 
 exports.internalFn = internalFn;
 Object.keys(external).forEach(function (k) {
-	if (k !== 'default' && !exports.hasOwnProperty(k)) Object.defineProperty(exports, k, {
+	if (k !== 'default' && !Object.prototype.hasOwnProperty.call(exports, k)) Object.defineProperty(exports, k, {
 		enumerable: true,
 		get: function () { return external[k]; }
 	});

test/form/samples/export-all-before-named/_expected/iife.js

@@ -7,7 +7,7 @@ var exposedInternals = (function (exports, external) {
 
 	exports.internalFn = internalFn;
 	Object.keys(external).forEach(function (k) {
-		if (k !== 'default' && !exports.hasOwnProperty(k)) Object.defineProperty(exports, k, {
+		if (k !== 'default' && !Object.prototype.hasOwnProperty.call(exports, k)) Object.defineProperty(exports, k, {
 			enumerable: true,
 			get: function () { return external[k]; }
 		});

test/form/samples/export-all-before-named/_expected/umd.js

@@ -10,7 +10,7 @@
 
 	exports.internalFn = internalFn;
 	Object.keys(external).forEach(function (k) {
-		if (k !== 'default' && !exports.hasOwnProperty(k)) Object.defineProperty(exports, k, {
+		if (k !== 'default' && !Object.prototype.hasOwnProperty.call(exports, k)) Object.defineProperty(exports, k, {
 			enumerable: true,
 			get: function () { return external[k]; }
 		});

test/form/samples/export-all-multiple/_expected/amd.js

@@ -3,19 +3,19 @@ define(['exports', 'foo', 'bar', 'baz'], (function (exports, foo, bar, baz) { 'u
 
 
 	Object.keys(foo).forEach(function (k) {
-		if (k !== 'default' && !exports.hasOwnProperty(k)) Object.defineProperty(exports, k, {
+		if (k !== 'default' && !Object.prototype.hasOwnProperty.call(exports, k)) Object.defineProperty(exports, k, {
 			enumerable: true,
 			get: function () { return foo[k]; }
 		});
 	});
 	Object.keys(bar).forEach(function (k) {
-		if (k !== 'default' && !exports.hasOwnProperty(k)) Object.defineProperty(exports, k, {
+		if (k !== 'default' && !Object.prototype.hasOwnProperty.call(exports, k)) Object.defineProperty(exports, k, {
 			enumerable: true,
 			get: function () { return bar[k]; }
 		});
 	});
 	Object.keys(baz).forEach(function (k) {
-		if (k !== 'default' && !exports.hasOwnProperty(k)) Object.defineProperty(exports, k, {
+		if (k !== 'default' && !Object.prototype.hasOwnProperty.call(exports, k)) Object.defineProperty(exports, k, {
 			enumerable: true,
 			get: function () { return baz[k]; }
 		});

test/form/samples/export-all-multiple/_expected/cjs.js

@@ -7,19 +7,19 @@ var baz = require('baz');
 
 
 Object.keys(foo).forEach(function (k) {
-	if (k !== 'default' && !exports.hasOwnProperty(k)) Object.defineProperty(exports, k, {
+	if (k !== 'default' && !Object.prototype.hasOwnProperty.call(exports, k)) Object.defineProperty(exports, k, {
 		enumerable: true,
 		get: function () { return foo[k]; }
 	});
 });
 Object.keys(bar).forEach(function (k) {
-	if (k !== 'default' && !exports.hasOwnProperty(k)) Object.defineProperty(exports, k, {
+	if (k !== 'default' && !Object.prototype.hasOwnProperty.call(exports, k)) Object.defineProperty(exports, k, {
 		enumerable: true,
 		get: function () { return bar[k]; }
 	});
 });
 Object.keys(baz).forEach(function (k) {
-	if (k !== 'default' && !exports.hasOwnProperty(k)) Object.defineProperty(exports, k, {
+	if (k !== 'default' && !Object.prototype.hasOwnProperty.call(exports, k)) Object.defineProperty(exports, k, {
 		enumerable: true,
 		get: function () { return baz[k]; }
 	});

test/form/samples/export-all-multiple/_expected/iife.js

@@ -4,19 +4,19 @@ var myBundle = (function (exports, foo, bar, baz) {
 
 
 	Object.keys(foo).forEach(function (k) {
-		if (k !== 'default' && !exports.hasOwnProperty(k)) Object.defineProperty(exports, k, {
+		if (k !== 'default' && !Object.prototype.hasOwnProperty.call(exports, k)) Object.defineProperty(exports, k, {
 			enumerable: true,
 			get: function () { return foo[k]; }
 		});
 	});
 	Object.keys(bar).forEach(function (k) {
-		if (k !== 'default' && !exports.hasOwnProperty(k)) Object.defineProperty(exports, k, {
+		if (k !== 'default' && !Object.prototype.hasOwnProperty.call(exports, k)) Object.defineProperty(exports, k, {
 			enumerable: true,
 			get: function () { return bar[k]; }
 		});
 	});
 	Object.keys(baz).forEach(function (k) {
-		if (k !== 'default' && !exports.hasOwnProperty(k)) Object.defineProperty(exports, k, {
+		if (k !== 'default' && !Object.prototype.hasOwnProperty.call(exports, k)) Object.defineProperty(exports, k, {
 			enumerable: true,
 			get: function () { return baz[k]; }
 		});

test/form/samples/export-all-multiple/_expected/umd.js

@@ -5,19 +5,19 @@
 })(this, (function (exports, foo, bar, baz) { 'use strict';
 
 	Object.keys(foo).forEach(function (k) {
-		if (k !== 'default' && !exports.hasOwnProperty(k)) Object.defineProperty(exports, k, {
+		if (k !== 'default' && !Object.prototype.hasOwnProperty.call(exports, k)) Object.defineProperty(exports, k, {
 			enumerable: true,
 			get: function () { return foo[k]; }
 		});
 	});
 	Object.keys(bar).forEach(function (k) {
-		if (k !== 'default' && !exports.hasOwnProperty(k)) Object.defineProperty(exports, k, {
+		if (k !== 'default' && !Object.prototype.hasOwnProperty.call(exports, k)) Object.defineProperty(exports, k, {
 			enumerable: true,
 			get: function () { return bar[k]; }
 		});
 	});
 	Object.keys(baz).forEach(function (k) {
-		if (k !== 'default' && !exports.hasOwnProperty(k)) Object.defineProperty(exports, k, {
+		if (k !== 'default' && !Object.prototype.hasOwnProperty.call(exports, k)) Object.defineProperty(exports, k, {
 			enumerable: true,
 			get: function () { return baz[k]; }
 		});