change Object.values/Object.entries to O from PF

rollup · Jul 25, 2023 · db8fd44 · db8fd44
1 parent 2e7c7fd
commit db8fd44
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/src/ast/nodes/shared/knownGlobals.ts b/src/ast/nodes/shared/knownGlobals.ts
@@ -253,8 +253,8 @@ const knownGlobals: GlobalDescription = {
 		isSealed: PF,
 		keys: PF,
 		fromEntries: O,
-		entries: PF,
-		values: PF,
+		entries: O,
+		values: O,
 		prototype: O
 	},
 	parseFloat: PF,

diff --git a/test/function/samples/tree-shake-object-with-sideeffctful-getter/_config.js b/test/function/samples/tree-shake-object-with-sideeffctful-getter/_config.js
@@ -0,0 +1,3 @@
+module.exports = {
+	description: 'retain functions that accept a object with a getter that has side effects'
+};
diff --git a/test/function/samples/tree-shake-object-with-sideeffctful-getter/main.js b/test/function/samples/tree-shake-object-with-sideeffctful-getter/main.js
@@ -0,0 +1,13 @@
+let effects = 0;
+
+const obj = {
+	get foo() {
+		effects++;
+		return "foo";
+	}
+};
+
+Object.values(obj);
+Object.entries(obj);
+
+assert.equal(effects, 2);