Skip to content

Commit

Permalink
Fix existing tests
Browse files Browse the repository at this point in the history
  • Loading branch information
lukastaegert committed Jan 10, 2020
1 parent bd0b13a commit ec04aa2
Show file tree
Hide file tree
Showing 2 changed files with 41 additions and 7 deletions.
39 changes: 34 additions & 5 deletions test/function/samples/context-resolve/_config.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ const tests = [
expected: {
id: path.resolve(__dirname, 'existing.js'),
external: false,
inlineDynamicImport: false,
moduleSideEffects: true
}
},
Expand All @@ -23,6 +24,7 @@ const tests = [
expected: {
id: path.resolve(__dirname, 'marked-directly-external-relative'),
external: true,
inlineDynamicImport: false,
moduleSideEffects: true
}
},
Expand All @@ -31,36 +33,63 @@ const tests = [
expected: {
id: path.resolve(__dirname, 'marked-external-relative'),
external: true,
inlineDynamicImport: false,
moduleSideEffects: true
}
},
{
source: 'marked-external-absolute',
expected: { id: 'marked-external-absolute', external: true, moduleSideEffects: true }
expected: {
id: 'marked-external-absolute',
external: true,
inlineDynamicImport: false,
moduleSideEffects: true
}
},
{
source: 'resolved-name',
expected: { id: 'resolved:resolved-name', external: false, moduleSideEffects: true }
expected: {
id: 'resolved:resolved-name',
external: false,
inlineDynamicImport: false,
moduleSideEffects: true
}
},
{
source: 'resolved-false',
expected: { id: 'resolved-false', external: true, moduleSideEffects: true }
expected: {
id: 'resolved-false',
external: true,
inlineDynamicImport: false,
moduleSideEffects: true
}
},
{
source: 'resolved-object',
expected: { id: 'resolved:resolved-object', external: false, moduleSideEffects: true }
expected: {
id: 'resolved:resolved-object',
external: false,
inlineDynamicImport: false,
moduleSideEffects: true
}
},
{
source: 'resolved-object-non-external',
expected: {
id: 'resolved:resolved-object-non-external',
external: false,
inlineDynamicImport: false,
moduleSideEffects: true
}
},
{
source: 'resolved-object-external',
expected: { id: 'resolved:resolved-object-external', external: true, moduleSideEffects: true }
expected: {
id: 'resolved:resolved-object-external',
external: true,
inlineDynamicImport: false,
moduleSideEffects: true
}
}
];

Expand Down
9 changes: 7 additions & 2 deletions test/incremental/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,13 @@ describe('incremental', () => {
assert.equal(bundle.cache.modules[1].id, 'entry');

assert.deepEqual(bundle.cache.modules[1].resolvedIds, {
foo: { id: 'foo', external: false, moduleSideEffects: true },
external: { id: 'external', external: true, moduleSideEffects: true }
foo: { id: 'foo', external: false, inlineDynamicImport: false, moduleSideEffects: true },
external: {
id: 'external',
external: true,
inlineDynamicImport: false,
moduleSideEffects: true
}
});
});
});
Expand Down

0 comments on commit ec04aa2

Please sign in to comment.