Do not check over parameters when finding possible star in default ex…

…ported function (#3522)

src/ast/nodes/ExportDefaultDeclaration.ts

@@ -23,10 +23,18 @@ function getDeclarationStart(code: string, start: number) {
 	return start;
 }
 
-function getIdInsertPosition(code: string, declarationKeyword: string, start: number) {
+function getIdInsertPosition(
+	code: string,
+	declarationKeyword: string,
+	endMarker: string,
+	start: number
+) {
 	const declarationEnd =
 		findFirstOccurrenceOutsideComment(code, declarationKeyword, start) + declarationKeyword.length;
-	code = code.slice(declarationEnd, findFirstOccurrenceOutsideComment(code, '{', declarationEnd));
+	code = code.slice(
+		declarationEnd,
+		findFirstOccurrenceOutsideComment(code, endMarker, declarationEnd)
+	);
 	const generatorStarPos = findFirstOccurrenceOutsideComment(code, '*');
 	if (generatorStarPos === -1) {
 		return declarationEnd;
@@ -71,6 +79,7 @@ export default class ExportDefaultDeclaration extends NodeBase {
 				code,
 				declarationStart,
 				'function',
+				'(',
 				this.declaration.id === null,
 				options
 			);
@@ -79,6 +88,7 @@ export default class ExportDefaultDeclaration extends NodeBase {
 				code,
 				declarationStart,
 				'class',
+				'{',
 				this.declaration.id === null,
 				options
 			);
@@ -106,6 +116,7 @@ export default class ExportDefaultDeclaration extends NodeBase {
 		code: MagicString,
 		declarationStart: number,
 		declarationKeyword: string,
+		endMarker: string,
 		needsId: boolean,
 		options: RenderOptions
 	) {
@@ -115,7 +126,7 @@ export default class ExportDefaultDeclaration extends NodeBase {
 
 		if (needsId) {
 			code.appendLeft(
-				getIdInsertPosition(code.original, declarationKeyword, declarationStart),
+				getIdInsertPosition(code.original, declarationKeyword, endMarker, declarationStart),
 				` ${name}`
 			);
 		}

test/form/samples/slash-in-function-parameters/_config.js

@@ -0,0 +1,3 @@
+module.exports = {
+	description: 'handles slashes in function parameters and correctly inserts missing ids'
+};

test/form/samples/slash-in-function-parameters/_expected/amd.js

@@ -0,0 +1,9 @@
+define(function () { 'use strict';
+
+	class someClass {}
+
+	function someFunction (text = '/') {}
+
+	console.log(someClass, someFunction);
+
+});

test/form/samples/slash-in-function-parameters/_expected/cjs.js

@@ -0,0 +1,7 @@
+'use strict';
+
+class someClass {}
+
+function someFunction (text = '/') {}
+
+console.log(someClass, someFunction);

test/form/samples/slash-in-function-parameters/_expected/es.js

@@ -0,0 +1,5 @@
+class someClass {}
+
+function someFunction (text = '/') {}
+
+console.log(someClass, someFunction);

test/form/samples/slash-in-function-parameters/_expected/iife.js

@@ -0,0 +1,10 @@
+(function () {
+	'use strict';
+
+	class someClass {}
+
+	function someFunction (text = '/') {}
+
+	console.log(someClass, someFunction);
+
+}());

test/form/samples/slash-in-function-parameters/_expected/system.js

@@ -0,0 +1,14 @@
+System.register([], function () {
+	'use strict';
+	return {
+		execute: function () {
+
+			class someClass {}
+
+			function someFunction (text = '/') {}
+
+			console.log(someClass, someFunction);
+
+		}
+	};
+});

test/form/samples/slash-in-function-parameters/_expected/umd.js

@@ -0,0 +1,12 @@
+(function (factory) {
+	typeof define === 'function' && define.amd ? define(factory) :
+	factory();
+}((function () { 'use strict';
+
+	class someClass {}
+
+	function someFunction (text = '/') {}
+
+	console.log(someClass, someFunction);
+
+})));

test/form/samples/slash-in-function-parameters/class.js

@@ -0,0 +1,3 @@
+export default class {}
+
+function* doesNotMatter() {}

test/form/samples/slash-in-function-parameters/function.js

@@ -0,0 +1,3 @@
+export default function (text = '/') {}
+
+function* doesNotMatter() {}

test/form/samples/slash-in-function-parameters/main.js

@@ -0,0 +1,4 @@
+import someClass from './class.js';
+import someFunction from './function';
+
+console.log(someClass, someFunction);