Named import alias used as a function's name

[quantizor]

For a sample component:

import React from 'react';
import {render, unmountComponentAtNode} from 'react-dom';

export default class Portal extends React.Component {
    static defaultProps = {
        destination: document.body,
    }

    id = 'foo'

    // the <div> that the children are rendered into
    $portal = null

    // the top-level child rendered into the $portal
    $passenger = null;

    componentWillMount() {
        this.$portal = document.createElement('div');
        this.props.destination.appendChild(this.$portal);

        this.renderPortalledContent();
    }

    renderPortalledContent() {
        const child = React.isValidElement(this.props.children) ? this.props.children : (<div>{this.props.children}</div>);

        this.$portal.id = this.id;

        render(child, this.$portal);
        this.$passenger = this.$portal.children[0];
    }

    componentDidUpdate() { this.renderPortalledContent(); }

    componentWillUnmount() {
        unmountComponentAtNode(this.$portal);
        this.props.destination.removeChild(this.$portal);
    }

    render() {
        return (<span />);
    }
}

I'm seeing the output I'm seeing this for the Portal.prototype.render entry:

{
        key: 'render',
        value: function reactDom.render() {
            return React__default.createElement('span', _extends({}, omitKeysFromSourceObject(this.props, UIPortal.internalKeys), { 'data-portal-id': this.props.portalId || this.id }));
        }
 }

Note the value: function reactDom.render() { part, which is invalid JS.

Seeing this in 0.36.3.

[Rich-Harris]

Do you have a repro you can share? Thanks

[Rich-Harris]

No need to worry about that repro – encountered the same bug myself (in Rollup's own codebase, embarrassingly enough!). Fix inbound

[Rich-Harris]

Fixed in 0.38

[quantizor]

Ah thank you! Do you have an open collective? I'd be happy to donate. Your work is much appreciated and moves the community forward ❤️

…

On Dec 21, 2016 7:54 PM, "Rich Harris" ***@***.***> wrote: Fixed in 0.38 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1083 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAiy1szyE_PUyO8yv4DhWsC6lhxaFcekks5rKcopgaJpZM4KhtxJ> .

[Rich-Harris]

@yaycmyk no, I don't – maybe we'll set one up one day! Thanks, it means a lot