globals/external not working as expected

[caub]

In this repo: https://github.com/caub/Leaflet.Terminator/blob/npm/rollup.config.js

  name: 'leaflet.terminator',
  external: ['leaflet'],
  globals: {
    'leaflet': 'L'
  },

output generated: (format :'umd')

(function (global, factory) {
	typeof exports === 'object' && typeof module !== 'undefined' ? module.exports = factory(require('leaflet')) :
	typeof define === 'function' && define.amd ? define(['leaflet'], factory) :
	(global.leaflet = global.leaflet || {}, global.leaflet.terminator = factory(global.L));
}(this, (function (L) { 'use strict';

L = L && L.hasOwnProperty('default') ? L['default'] : L;
// ........

I expect that L is used in the output, but global.leaflet is still there, so I made this hacky plugin, in the hope rollup has a better way

As you can see, only the UMD header has this issue

I've read the docs, and issues on external/globals, yet I can't figure this

rollup: "^0.51.7"

[caub]

Hmm it'd work if I set name: 'L.terminator', since name is put in https://github.com/rollup/rollup/blob/master/src/finalisers/umd.js#L16, it's a bit magic, but ok

[lukastaegert]

Hi @caub, did you try @adrianheine 's PR by installing rollup via

npm install adrianheine/rollup#master

? Does it work for you? If so I would put this into the next release.