Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreachable code not removed #2319

Closed
Andarist opened this issue Jul 3, 2018 · 5 comments · Fixed by #3153
Closed

Unreachable code not removed #2319

Andarist opened this issue Jul 3, 2018 · 5 comments · Fixed by #3153

Comments

@Andarist
Copy link
Member

Andarist commented Jul 3, 2018

Reproduction

Basically unused functions (and probably other things too) do not get tree-shaken if they are unreachable

@lukastaegert
Copy link
Member

At the moment, rollup does not handle early returns but there are several ways of doing this. I hope we can improve this at some point.

@Andarist
Copy link
Member Author

Andarist commented Jul 3, 2018

Oh, I havent realized early returns are a special case. If there is some other issue tracking this, feel free to close this one.

@lukastaegert
Copy link
Member

As a matter of fact I think this is the first issue about this :)

@shellscape
Copy link
Contributor

Hey folks. This is a saved-form message, but rest assured we mean every word. The Rollup team is attempting to clean up the Issues backlog in the hopes that the active and still-needed, still-relevant issues bubble up to the surface. With that, we're closing issues that have been open for an eon or two, and have gone stale like pirate hard-tack without activity.

We really appreciate the folks have taken the time to open and comment on this issue. Please don't confuse this closure with us not caring or dismissing your issue, feature request, discussion, or report. The issue will still be here, just in a closed state. If the issue pertains to a bug, please re-test for the bug on the latest version of Rollup and if present, please tag @shellscape and request a re-open, and we'll be happy to oblige.

@lukastaegert
Copy link
Member

I hope to be able to address this one soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

4 participants