-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of immutable.js and implement tree-shaking for broken control flow #3153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: recursion prevention TODO: replace "immutable" in the immutable entity path tracker
Codecov Report
@@ Coverage Diff @@
## master #3153 +/- ##
==========================================
+ Coverage 89.32% 90.12% +0.79%
==========================================
Files 165 165
Lines 5734 5874 +140
Branches 1739 1790 +51
==========================================
+ Hits 5122 5294 +172
+ Misses 379 350 -29
+ Partials 233 230 -3
Continue to review full report at Codecov.
|
7 tasks
lukastaegert
force-pushed
the
mutable-tree-shaking
branch
from
October 15, 2019 04:58
9aa89b8
to
69cbd75
Compare
lukastaegert
force-pushed
the
mutable-tree-shaking
branch
from
October 15, 2019 05:26
69cbd75
to
8949aaa
Compare
Dope 😍 |
This was referenced Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #2319
Description
This is a big thing I have been working on the past weeks.
Here, the last log would be the only thing left in the function:
And similar logic for switch statements and all kinds of loops. This is heavily tested but considering the possible combinatorics, it is still possible I missed things so it would be cool if some people tried it out.