Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

var exports.foo #426

Closed
Rich-Harris opened this issue Jan 5, 2016 · 3 comments
Closed

var exports.foo #426

Rich-Harris opened this issue Jan 5, 2016 · 3 comments

Comments

@Rich-Harris
Copy link
Contributor

This clearly shouldn't happen...

@Rich-Harris
Copy link
Contributor Author

Easy way to fix this would be to remove the var declaration. But underlying issue is that we're marking foo as something that gets reassigned, and therefore needs to be rewritten as exports.foo (rather than just declaring it and later doing export { foo }), when in actual fact it isn't reassigned; it was never initialised (and even if it was reassigned, it doesn't happen inside a function, which means there's no danger of the value changing after it gets exported).

So there's actually two issues here.

@mbostock
Copy link
Contributor

mbostock commented Jan 9, 2016

A shot in the dark, but this looks related to #438.

Rich-Harris added a commit that referenced this issue Jan 18, 2016
Rich-Harris added a commit that referenced this issue Jan 18, 2016
@Rich-Harris
Copy link
Contributor Author

Fixed in 0.25.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants