Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails on computed object literal keys #434

Closed
twhb opened this issue Jan 7, 2016 · 3 comments
Closed

Fails on computed object literal keys #434

twhb opened this issue Jan 7, 2016 · 3 comments

Comments

@twhb
Copy link

twhb commented Jan 7, 2016

Given the code var x = {[foo]: 'bar'};, rollup seems to be unaware that the variable foo is used. It will remove foo's declaration if it is not used elsewhere, or, if foo is renamed to avoid conflict with another file, will not rename the reference in the object literal (causing it to refer to the wrong value).

@Victorystick
Copy link
Contributor

Reproduced on Rollup's site.

@Rich-Harris
Copy link
Contributor

Thanks – released 0.24.1 with the fix

@twhb
Copy link
Author

twhb commented Jan 9, 2016

Love the turnaround time, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants