Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails with export {} #486

Closed
Rich-Harris opened this issue Jan 31, 2016 · 2 comments
Closed

Fails with export {} #486

Rich-Harris opened this issue Jan 31, 2016 · 2 comments
Labels
t¹ 🐞 bug

Comments

@Rich-Harris
Copy link
Contributor

Via rollup/rollup-plugin-babel#37
@Rich-Harris Rich-Harris mentioned this issue Jan 31, 2016
Closed
@Pauan
Copy link
Contributor

Pauan commented Feb 1, 2016

In my opinion, I'm fine with Rollup not allowing export {}

However, it should fail with a descriptive error such as Empty export is not allowed

Rich-Harris added a commit that referenced this issue Feb 6, 2016
@Rich-Harris
warn on empty exports, dont fail (closes #486)
ab767b1
@Rich-Harris Rich-Harris mentioned this issue Feb 6, 2016
Merged
@Rich-Harris
Copy link
Contributor Author

Have opened #498. I don't think it should fail, since it's not disallowed by the spec and Acorn parses it just fine. But it is probably worth a warning, since it'd be hard to understand what was causing rollup/rollup-plugin-babel#37 otherwise

Rich-Harris added a commit that referenced this issue Feb 14, 2016
@Rich-Harris
Merge pull request #498 from rollup/gh-486
157ba12 
warn on empty exports, don't fail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t¹ 🐞 bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Pauan @Rich-Harris