Rollup shouldn't close stdout or subsequent writes will fail.

[mlstich]

Expected Behavior / Situation

The expected behaviour is the one before #4983 - not to close stdout with process.stdout.end(). Subsequent writes to stdout (through node) will continue to be successful.

Actual Behavior / Situation

With #4983 / Rollup v3.21.6, stdout is closed. Subsequent writes to stdout will fail.

Our specific case:

• We use the Firebase action-hosting-deploy GitHub action to deploy to firebase.
• We use a predeploy hook to invoke rollup as part of the deployment.
• With v3.21.6 this started to fail because stdout (within node) is closed after the rollup commands but the GitHub action looks for the success message from deployment in that log (see https://github.com/FirebaseExtended/action-hosting-deploy/blob/4d0d0023f1d92b9b7d16dda64b3d7abd2c98974b/src/deploy.ts#L150).

Modification Proposal

Roll back the change in #4983 (and solve it differently, without affecting the node process beyond Rollup).

[lukastaegert]

Are you calling Rollup CLI as a Node script instead of as a separate process? How is it a problem that we close stdout but not that we call process.exit? the change was introduced because explicitly calling process.exit was aborting the CLI before stdout was fully written. Explicit process.exit on the other hand solved issues with Rollup not closing in certain configurations.

[mlstich]

Are you calling Rollup CLI as a Node script instead of as a separate process?

Yes, you can put it that way. The GitHub action does that. Using the firebase CLI alone doesn't produce the issue.

How is it a problem that we close stdout but not that we call process.exit

Good point! I'm not familiar with how processes are managed in node unfortunately.

I created a repro to demonstrate the issue: https://github.com/mlstich/rollup-stdout-repro.

[mlstich]

Workaround (as an alternative to pinning the dependency): Redirect stdout to /dev/null when invoking rollup:

rollup main.js --file bundle.js > /dev/null

[lukastaegert]

Fix at #5004

[rollup-bot]

This issue has been resolved via #5004 as part of rollup@3.22.1. You can test it via npm install rollup.

[mlstich]

Awesome, thanks for the fix!