Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linux arm musl build #5471

Merged
merged 2 commits into from Apr 15, 2024
Merged

Conversation

sapphi-red
Copy link
Contributor

@sapphi-red sapphi-red commented Apr 14, 2024

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Adds linux arm musl build.
I changed to use strip = true in Cargo.toml instead of running strip commands because it takes effort to get the strip command binary for arm musl.

refs napi-rs/napi-rs#2020

Copy link

vercel bot commented Apr 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2024 11:15am

Copy link

codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.81%. Comparing base (7275328) to head (a497644).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5471   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files         238      238           
  Lines        9450     9450           
  Branches     2407     2407           
=======================================
  Hits         9338     9338           
  Misses         47       47           
  Partials       65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sapphi-red sapphi-red marked this pull request as ready for review April 14, 2024 11:32
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing this works now, I remember losing a day over this. And I guess stripping by default makes things easier, though of course it means we can now only easily debug with the development build, but I guess that is fine. Thanks so much for your effort!

@lukastaegert lukastaegert added this pull request to the merge queue Apr 15, 2024
Merged via the queue into rollup:master with commit 49ed6d9 Apr 15, 2024
31 checks passed
Copy link

This PR has been released as part of rollup@4.14.3. You can test it via npm install rollup.

@sapphi-red sapphi-red deleted the add-linux-armv7-musl branch April 15, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to run on arm platforms
2 participants