-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linux arm musl build #5471
Add linux arm musl build #5471
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5471 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 238 238
Lines 9450 9450
Branches 2407 2407
=======================================
Hits 9338 9338
Misses 47 47
Partials 65 65 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing this works now, I remember losing a day over this. And I guess stripping by default makes things easier, though of course it means we can now only easily debug with the development build, but I guess that is fine. Thanks so much for your effort!
This PR has been released as part of rollup@4.14.3. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Adds linux arm musl build.
I changed to use
strip = true
inCargo.toml
instead of runningstrip
commands because it takes effort to get the strip command binary for arm musl.refs napi-rs/napi-rs#2020