Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: Cannot read property 'indexOf' of undefined #743

Closed
mbostock opened this issue Jun 22, 2016 · 1 comment · Fixed by #744
Closed

TypeError: Cannot read property 'indexOf' of undefined #743

mbostock opened this issue Jun 22, 2016 · 1 comment · Fixed by #744

Comments

@mbostock
Copy link
Contributor

I just upgraded to 0.32, and now I get a TypeError. My command-line is:

rollup --banner "$(preamble)" -f umd -g d3-time:d3 -n d3 -o build/d3-time-format.js -- index.js

(See d3-time-format.)

It’s trying to do this:

// Add missing Module IDs to external.
if ( external.indexOf( names[0] ) === -1 ) {
  external.push( names[0] );
}

And external is undefined. This appears related to 9461ed3.

Rich-Harris added a commit that referenced this issue Jun 23, 2016
Rich-Harris added a commit that referenced this issue Jun 23, 2016
allow --globals to work with --external and options.external in whatever configuration
@Rich-Harris
Copy link
Contributor

Whoops! Fixed in 0.32.2, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants