Incomplete tree shaking (cjs?)

[Benjamin-Dobell]

Version

"rollup version 0.34.13"

Details

I have an ES6 module ("dom") that looks like this:

// ... code ...

var isDescendant = function(parent, child) {
    // ... code ...
};

// ... code ...

export {
    addEventListener,
    getElementContentWidth,
    getElementContentHeight,
    removeAllChildren,
    isDescendant,
    loadCss
};

The tree shaking is detecting that isDescendant is not called, and hence:

var isDescendant = function(parent, child) {
    // ... code ...
};

is completely removed from my target CJS bundle.

However, the "transpiled" export referring to isDescendent is left in place:

var dom = Object.freeze({
    addEventListener: addEventListener,
    getElementContentWidth: getElementContentWidth,
    getElementContentHeight: getElementContentHeight,
    removeAllChildren: removeAllChildren,
    isDescendant: isDescendant,
    loadCss: loadCss
});

Which results in "ReferenceError: isDescendant is not defined".

[TrySound]

@Benjamin-Dobell Like this?
example

[Benjamin-Dobell]

@TrySound I've worked out a minimum reproduction case. The indirection (namespace-like behaviour) seems to cause the issue:

example

[Rich-Harris]

Thanks, I've added that reproduction as a test case in #902, where it passes (rather than including the unusedFunc declaration, it knows that it doesn't need to reify the unused namespace in the first place – in other words, all the code disappears which is a better result)

[Rich-Harris]

Fixed in 0.35