Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup 0.35.4 breaks my build #919

Closed
alangpierce opened this issue Sep 10, 2016 · 2 comments · Fixed by #920
Closed

Rollup 0.35.4 breaks my build #919

alangpierce opened this issue Sep 10, 2016 · 2 comments · Fixed by #920

Comments

@alangpierce
Copy link

I'm getting a crash with this stack trace:

Cannot read property 'initialise' of null
TypeError: Cannot read property 'initialise' of null
    at ForStatement.initialise (/home/travis/build/alangpierce/bulk-decaffeinate/node_modules/rollup/src/ast/nodes/ForStatement.js:24:14)
    at BlockStatement.initialise (/home/travis/build/alangpierce/bulk-decaffeinate/node_modules/rollup/src/ast/nodes/BlockStatement.js:43:9)
    at eachChild.child (/home/travis/build/alangpierce/bulk-decaffeinate/node_modules/rollup/src/ast/Node.js:64:34)
    at IfStatement.eachChild (/home/travis/build/alangpierce/bulk-decaffeinate/node_modules/rollup/src/ast/Node.js:21:6)
    at IfStatement.initialise (/home/travis/build/alangpierce/bulk-decaffeinate/node_modules/rollup/src/ast/Node.js:64:8)
    at IfStatement.initialise (/home/travis/build/alangpierce/bulk-decaffeinate/node_modules/rollup/src/ast/nodes/IfStatement.js:11:11)
    at eachChild.child (/home/travis/build/alangpierce/bulk-decaffeinate/node_modules/rollup/src/ast/Node.js:64:34)
    at IfStatement.eachChild (/home/travis/build/alangpierce/bulk-decaffeinate/node_modules/rollup/src/ast/Node.js:21:6)
    at IfStatement.initialise (/home/travis/build/alangpierce/bulk-decaffeinate/node_modules/rollup/src/ast/Node.js:64:8)
    at IfStatement.initialise (/home/travis/build/alangpierce/bulk-decaffeinate/node_modules/rollup/src/ast/nodes/IfStatement.js:11:11)

See these greenkeeper PRs for links to the failing CI builds (which I also reproduced locally):
decaffeinate/bulk-decaffeinate#23
decaffeinate/decaffeinate#415

Looks like the crash was probably caused by this commit: 9d9cfcc
Rich-Harris added a commit that referenced this issue Sep 10, 2016
@Rich-Harris
allow empty for loop heads – fixes #919
eba7a70
@Rich-Harris Rich-Harris mentioned this issue Sep 10, 2016
Merged
Rich-Harris added a commit that referenced this issue Sep 10, 2016
@Rich-Harris
Merge pull request #920 from rollup/gh-919
9f490cc 
allow empty for loop heads
@Rich-Harris
Copy link
Contributor

Thanks – if my understanding of the bug is correct, it should be fixed by 0.35.5

@alangpierce
Copy link
Author

Yep, I just tried the build again with 0.35.5 and it works now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow empty for loop heads rollup/rollup
2 participants
@alangpierce @Rich-Harris