Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

else if branches with false condition dropped incorrectly in generated code #973

Closed
yyx990803 opened this issue Sep 22, 2016 · 3 comments
Closed

Comments

@yyx990803
Copy link
Contributor

yyx990803 commented Sep 22, 2016

repro

It seems when the condition for an else if branch is deterministically false (false, or something like 'production' === 'production'), rollup is being smart and trying to drop the branch, however outputting incorrect code.

This happens with all versions >=0.35.0.

@Victorystick
Copy link
Contributor

Nice catch! Thanks.

@Victorystick
Copy link
Contributor

@yyx990803 Got a patch on its way. You can expect it in 10 hours, after I've gotten some sleep. 😴

@Rich-Harris
Copy link
Contributor

Released 0.36.1 with the fix – thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants