-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
string '//# sourceMappingURL=' gets removed #988
Comments
See this source file for how Rollup circumvents this issue; and where it introduces it. |
Do you consider this a bug? |
I think it is, and the same applies to any other tools that indiscriminately remove all occurrences of that string. |
Check this out. Even if it's really a comment, the regular expression has a |
prevent false positives for sourcemapping url comments with newlines
thank you! |
Released 0.38 with the fix |
@Rich-Harris It's a lot better but still isn't entirely fixed. For instance, @thisconnect's original example could be rewritten like this. I'll leave it up to you whether this edge case is worth worrying about. |
@Permutatrix yeah, I missed that – fixed by #1171 |
http://rollupjs.org/?version=0.36.0&shareable=JTdCJTIyb3B0aW9ucyUyMiUzQSU3QiUyMmZvcm1hdCUyMiUzQSUyMmNqcyUyMiUyQyUyMm1vZHVsZU5hbWUlMjIlM0ElMjJteUJ1bmRsZSUyMiUyQyUyMmdsb2JhbHMlMjIlM0ElN0IlN0QlN0QlMkMlMjJtb2R1bGVzJTIyJTNBJTVCJTdCJTIybmFtZSUyMiUzQSUyMm1haW4uanMlMjIlMkMlMjJjb2RlJTIyJTNBJTIyaW1wb3J0JTIwYWRkTWFwcGluZyUyMGZyb20lMjAnLiUyRnRlc3QuanMnJTNCJTVDbmNvbnNvbGUubG9nKCUyMGFkZE1hcHBpbmcoJTIwJ3Rlc3QnJTIwKSUyMCklM0IlNUNuY29uc29sZS5sb2coJyU1QyU1Q24lMkYlMkYlMjMlMjBzb3VyY2VNYXBwaW5nVVJMJTNEJyklMjIlN0QlMkMlN0IlMjJuYW1lJTIyJTNBJTIydGVzdC5qcyUyMiUyQyUyMmNvZGUlMjIlM0ElMjJleHBvcnQlMjBkZWZhdWx0JTIwZnVuY3Rpb24lMjBhZGRNYXBwaW5nJTIwKCUyMG9yZyUyMCklMjAlN0IlNUNuJTVDdHJldHVybiUyMG9yZyUyMCUyQiUyMCclNUMlNUNuJTJGJTJGJTIzJTIwc291cmNlTWFwcGluZ1VSTCUzRCclNUNuJTdEJTIyJTdEJTVEJTdE
The text was updated successfully, but these errors were encountered: