Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

string '//# sourceMappingURL=' gets removed #988

Closed
thisconnect opened this issue Sep 26, 2016 · 8 comments
Closed

string '//# sourceMappingURL=' gets removed #988

thisconnect opened this issue Sep 26, 2016 · 8 comments

Comments

@Victorystick
Copy link
Contributor

See this source file for how Rollup circumvents this issue; and where it introduces it.

@thisconnect
Copy link
Author

Do you consider this a bug?

@Victorystick
Copy link
Contributor

I think it is, and the same applies to any other tools that indiscriminately remove all occurrences of that string.

@lemmabit
Copy link
Contributor

lemmabit commented Oct 3, 2016

Check this out. Even if it's really a comment, the regular expression has a \s in the middle of it, which will match the end of a multiline string.

@thisconnect
Copy link
Author

thank you!

@Rich-Harris
Copy link
Contributor

Released 0.38 with the fix

@lemmabit
Copy link
Contributor

@Rich-Harris It's a lot better but still isn't entirely fixed. For instance, @thisconnect's original example could be rewritten like this. I'll leave it up to you whether this edge case is worth worrying about.

@Rich-Harris
Copy link
Contributor

@Permutatrix yeah, I missed that – fixed by #1171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants