New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] remove Object.define for legacy; pass into cli; test legacy #1068

Merged

Rich-Harris merged 1 commit into rollup:master from futurist:master

Dec 12, 2016

Contributor

futurist commented Oct 20, 2016

This PR does below things for option.legacy=true

Remove Object.define esModule line
Also pass the legacy option to CLI
Test for the new code, fix previously legacy test use case.


          FIX: test for legacy; remove Object.define for legacy

d5997f3

futurist mentioned this pull request

Getters/setters should be removed somehow futurist/rollup-plugin-es3#3

Open

IvanSanchez mentioned this pull request

Do not output getter defs when in legacy mode #1069

Merged

Rich-Harris merged commit 9515730 into rollup:master

Contributor

Rich-Harris commented Dec 12, 2016

Thanks 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment