Babili's sourcemaps causes error in collapseSourcemaps.js #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The one line fix to src/utils/collapseSourcemaps.js is fine, but rollup shouldn't have a devDependency on babel, so the test is not required - unless it can be rewritten without babel. |
|
Sorry, I've found test with uglify.js and thought that I could do the same with Babili. I've simplified test. It doesn't require Babili anymore. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue described in #1254.
Due to Babili returning last line mapping with only one segment inside,
sourcevariable inLink.traceMappingsremains undefined and all operations on this variable fails.The proposed fix just checks if
sourceis really set before doing anything with it.