Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incorrect namespace conflict warning #1287

Merged
merged 1 commit into from
Mar 9, 2017
Merged

fix incorrect namespace conflict warning #1287

merged 1 commit into from
Mar 9, 2017

Conversation

olsonpm
Copy link
Contributor

@olsonpm olsonpm commented Jan 26, 2017

  • only set module.exportsAll when no conflict is found
  • fix warning in test

fix incorrect namespace conflict warning
6c0048d 
 - only set module.exportsAll when no conflict is found
 - fix warning in test
@olsonpm
Copy link
Contributor Author

olsonpm commented Jan 26, 2017

link to replication of the error being addressed

Note because it's a warning, you'll need the dev console open.

@Rich-Harris Rich-Harris merged commit ae54071 into rollup:master Mar 9, 2017
@Rich-Harris
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@olsonpm @Rich-Harris