options.amd #1365
Merged
options.amd #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Grouping together seems good, it was strange to have 2 related config options not actually grouped together.
cc @chadhietala |
|
@Rich-Harris looks good, got any cycles for a merge + release? |
|
will cut a release later today, apols for delay |
|
released 0.42 |
|
No prob. Also, congrats on the new gig! |
|
thanks mate! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #1363. I think it probably makes sense to group
moduleIdanddefineReplacementunder a singleamdoption, since it feels a bit neater and is possibly a bit more 'discoverable'.Also, this ought to apply to UMD output as well as AMD.
@stefanpenner thoughts?