Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run same options transform on generate for bundle #1463

Merged
merged 1 commit into from Jul 9, 2017

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Jun 22, 2017

Some recent changes introduced in 0.43.0 breaks the amd named module generation.

The checkOptions function is applied only on the main entry point (rollup), but not in the generate() function.

Basically when passing this options:

// Passing a set of options
rollup({ entry, plugins, ..otherOptions }).then(() => {
    ... 
   // Passing another set of options
    bundle.generate({ format: 'amd', moduleId: 'something' });
    ...

The output does respect the moduleId option, nor does it error out.

This change addresses this inconsistency, and it will give the same warning.

We tried to add a tests but the tests makes the assumption that both entry points rollup and bundle will receive the same options object, which is not necessarily imposed in the API.

//cc @pmdartus who coPR this.

@Rich-Harris Rich-Harris merged commit c026cb2 into rollup:master Jul 9, 2017
@Rich-Harris
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants