Run same options transform on generate for bundle #1463
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some recent changes introduced in
0.43.0
breaks the amd named module generation.The checkOptions function is applied only on the main entry point (rollup), but not in the generate() function.
Basically when passing this options:
The output does respect the
moduleId
option, nor does it error out.This change addresses this inconsistency, and it will give the same warning.
We tried to add a tests but the tests makes the assumption that both entry points rollup and bundle will receive the same options object, which is not necessarily imposed in the API.
//cc @pmdartus who coPR this.