Directive handling #1856
Directive handling #1856
Conversation
| @@ -0,0 +1,5 @@ | |||
| export var count = 0; | |||
There was a problem hiding this comment.
I assume this file can be deleted? 😉
|
Also, very nice tests! I am just doing some final checks before merging it. |
src/ast/nodes/ExpressionStatement.ts
Outdated
| shouldBeIncluded() { | ||
| if (this.directive && this.directive !== 'use strict') { | ||
| if (this.parent.type === "Program") { | ||
| this.module.warn( // This is necessary, because either way (deleting or not) can lead to errors. |
There was a problem hiding this comment.
shouldBeIncluded is run for each tree-shaking pass, which means the error is displayed at least twice, possibly more often. The rest of the code looks nice and I like the approach but the proper place to display the warning is to add a member initialiseNode, cf. e.g. the warning in ThisExpression. initialiseNode is run only once and is meant for node specific initialisations that do not depend on the scope being populated.
|
@lukastaegert are you planning releasing this feature or should I expect some delay (I see there is a nice progress on other PRs and issues) |
|
I plan on releasing this together with #1816 and possibly others maybe as early as tomorrow. It was just a little late for the previous release 😜 |
|
Sure, awesome! Keep up the amazing work |
|
@lukastaegert thanks! |
Improving directive handling, as discussed in #1855