chore: clean up internal types and install missing @types
#1858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
force-pushed
the
feature/clean-up-internal
branch
2 times, most recently
from
6a56d9e
to
a9c8216
Compare
alan-agius4
force-pushed
the
feature/clean-up-internal
branch
from
a9c8216
to
5073b09
Compare
lukastaegert
approved these changes
Jan 10, 2018
|
Actually in most cases you don’t need to add the internal keyword unless a
class or method is exposed and shouldn’t. As stripInternal will still
create some files but blank. I think overall we need to improve some
exports etc...
…On Wed, 10 Jan 2018 at 08:48, Lukas Taegert ***@***.***> wrote:
Merged #1858 <#1858>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1858 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AQv-WhpYXwhP50VuiYb7IcpOBAV9gD6Dks5tJGtogaJpZM4RYdd7>
.
|
|
Basicilly the the latest changes these are exported If you see anything that shouldn't be exported let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the first PRs to improve the TypeScript structure and eventually try to reduce the amount of outputted
.d.tsfiles