Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow plugin load() to return empty string #1908

Merged
merged 2 commits into from
Jan 26, 2018
Merged

Allow plugin load() to return empty string #1908

merged 2 commits into from
Jan 26, 2018

Conversation

erikdesjardins
Copy link
Contributor

@erikdesjardins erikdesjardins commented Jan 24, 2018 •
edited

Previously, this was only allowed when returning a source code string, not a { code, map } object, because source.code was checked for truthiness.

@erikdesjardins erikdesjardins mentioned this pull request Jan 24, 2018
Closed
lukastaegert
lukastaegert approved these changes Jan 25, 2018
View reviewed changes
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks 👍

@lukastaegert lukastaegert added this to the 0.55.1 milestone Jan 25, 2018
@lukastaegert lukastaegert changed the base branch from master to release-0.55.1 January 26, 2018 05:51
@lukastaegert lukastaegert merged commit 89aea1a into rollup:release-0.55.1 Jan 26, 2018
@erikdesjardins erikdesjardins deleted the load-empty-string branch January 26, 2018 15:01
@dependencies dependencies bot mentioned this pull request Jan 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.55.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erikdesjardins @lukastaegert