Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1910.
The main fix is just the line in
src/Chunk.ts
, but in the process this exposed an idempotency bug in the deshadowing process itself in thatsafeName
results from previous deshadowing runs can affect future runs.I've fixed the idempotency bug with a reliable but hacky approach for now, hopefully we can put some thought to something better here, but correctness comes first I feel. Just let me know if I can help explain it at all further.