-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activating Open Collective #1915
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I added some changes to the contributing file (that I can also easily do myself). The only major open question for me is who will receive emails from hello@rollup.opencollective.com?
CONTRIBUTING.md
Outdated
First, thank you for considering contributing to rollup! It's people like you that make the open source community such a great community! 😊 | ||
|
||
We welcome any type of contribution, not only code. You can help with | ||
- **QA**: file bug reports, the more details you can give the better (e.g. screenshots with the console open) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe
"file bug reports, the more details you can give the better (e.g. REPL-links or repos that demonstrate the specific issue)"
which is more helpful for the kind of issues people usually have with rollup :)
CONTRIBUTING.md
Outdated
## Code review process | ||
|
||
The bigger the pull request, the longer it will take to review and merge. Try to break down large pull requests in smaller chunks that are easier to review and merge. | ||
It is also always helpful to have some context for your pull request. What was the purpose? Why does it matter to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add "Does it resolve any known Github issues?"
CONTRIBUTING.md
Outdated
## Questions | ||
|
||
If you have any questions, create an [issue](issue) (protip: do a quick search first to see if someone else didn't ask the same question before!). | ||
You can also reach us at hello@rollup.opencollective.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who will receive these emails? If these only go to @Rich-Harris (who originally applied for Open Collective), this is probably not the best of ideas. My hunch is to remove this section as issues are still the single best way of getting yourself heard.
On the other hand, we are often flooded with support issues that divert our very limited resources from actually fixing or improving things so we might use this opportunity to divert these to other forums:
"If you require technical assistance, Stackoverflow or Gitter are usually the best places to start.
You can also create an issue (protip: do a quick search first to see if someone else didn't ask the same question before!)."
I'm really not a fan of these changes. It seems quite presumptuous to make people using Rollup to download a bunch of additional packages and to also use up a bunch of console real estate printing out some giant ASCII art. Installing just Rollup now installs 46 packages instead of just 1. I realize the desire to make people aware of OpenCollective and to donate to Rollup if they are able, but I don't think 64fad16 is a good way to go about that. |
I wanted to give it a try to see how it feels but I guess you're right, we should remove this particular change again. |
I have removed it on master so that it will vanish with the next release. |
Yes, the postinstall works great for some repos, but it really isn't for everyone. I understand when people don't want to include it. You can definitely ignore that part. If you ever come to the point where you want to reach folks postinstall, there are alternatives that open collective is aware of: One user made a lighter version of the post install: https://github.com/WebReflection/lightercollective |
Thanks, I guess the minimal "echo" version might make sense. I decided to release it without the message for now (i.e. v0.55.3 is now live) since I think OpenCollective is now featured very prominently in the Readme as well as the issue template and contribution guidelines. |
Looks like this came back in 0.55.4? |
I assume one of the PRs somehow brought this back, sorry about that. Just released a small patch that fixes this again. |
This pull request adds backers and sponsors from your Open Collective https://opencollective.com/rollup ❤️
It adds two badges at the top to show the latest number of backers and sponsors. It also adds placeholders so that the avatar/logo of new backers/sponsors can automatically be shown without having to update your README.md. [more info]. See how it looks on this repo.
We have also added a
postinstall
script to let people know afternpm|yarn install
that you are welcoming donations (optional). [More info]You can also add a "Donate" button to your website and automatically show your backers and sponsors there with our widgets. Have a look here: https://opencollective.com/widgets
P.S: As with any pull request, feel free to comment or suggest changes. The only thing "required" are the placeholders on the README because we believe it's important to acknowledge the people in your community that are contributing (financially or with code!).
Thank you for your great contribution to the open source community. You are awesome! 🙌
And welcome to the open collective community! 😊
Come chat with us in the #opensource channel on https://slack.opencollective.com - great place to ask questions and share best practices with other open source sustainers!