Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enabled testing directory structures in chunked mode #1924

Merged
merged 1 commit into from
Feb 9, 2018
Merged

enabled testing directory structures in chunked mode #1924

merged 1 commit into from
Feb 9, 2018

Conversation

kellyselden
Copy link
Contributor

Extracted from #1922.

Allows comparing directory trees, instead of just top-level files.

@kellyselden
Copy link
Contributor Author

Any objections to this?

guybedford
guybedford approved these changes Feb 8, 2018
View reviewed changes
Copy link
Contributor

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this one somehow. Looks good to me. Perhaps we should even refactor the main tests to use the same as well, since this is just a copy of the standard form tests code.

@lukastaegert lukastaegert added this to the 0.55.4 milestone Feb 9, 2018
@lukastaegert lukastaegert merged commit 88e0cf4 into rollup:master Feb 9, 2018
@kellyselden kellyselden deleted the test-dirs branch February 9, 2018 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guybedford guybedford guybedford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.55.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kellyselden @guybedford @lukastaegert