Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tree-shaking rendering #1949

Merged
merged 27 commits into from
Feb 15, 2018
Merged

Refactor tree-shaking rendering #1949

merged 27 commits into from
Feb 15, 2018

Commits on Feb 11, 2018

  1. Make BlockStatements take care of removing their children

    @lukastaegert
    lukastaegert committed Feb 11, 2018
    Configuration menu
    Copy the full SHA
    4b9dfc3 View commit details
    Browse the repository at this point in the history

  2. Extract BlockStatement rendering to be used for Program nodes with 

    exceptions for IfStatements and ExportDefaultDeclarations for now
    @lukastaegert
    lukastaegert committed Feb 11, 2018
    Configuration menu
    Copy the full SHA
    2436ee1 View commit details
    Browse the repository at this point in the history

  3. Use new logic for switch statements (which works much better than the 

    old logic but can leave trailing comments and line-breaks as the
SwitchCase length provided by acorn does not include those)
    @lukastaegert
    lukastaegert committed Feb 11, 2018
    Configuration menu
    Copy the full SHA
    48f4683 View commit details
    Browse the repository at this point in the history

  4. * Properly handle multi-line comments after statements 

    * Skip unnecessary calculations
    @lukastaegert
    lukastaegert committed Feb 11, 2018
    Configuration menu
    Copy the full SHA
    152eb29 View commit details
    Browse the repository at this point in the history

  5. Refactor and simplify default export rendering

    @lukastaegert
    lukastaegert committed Feb 11, 2018
    Configuration menu
    Copy the full SHA
    eae7d96 View commit details
    Browse the repository at this point in the history

  6. Clean up code, improve performance and resolve #1850

    @lukastaegert
    lukastaegert committed Feb 11, 2018
    Configuration menu
    Copy the full SHA
    c345fb5 View commit details
    Browse the repository at this point in the history

  7. Resolve #1772

    @lukastaegert
    lukastaegert committed Feb 11, 2018
    Configuration menu
    Copy the full SHA
    7781b5f View commit details
    Browse the repository at this point in the history

  8. Remove "statement" concept and other remains of old positioning logic

    @lukastaegert
    lukastaegert committed Feb 11, 2018
    Configuration menu
    Copy the full SHA
    698f3a2 View commit details
    Browse the repository at this point in the history

  9. When checking for symbols other than line-breaks, check for both kinds 

    of comments
    @lukastaegert
    lukastaegert committed Feb 11, 2018
    Configuration menu
    Copy the full SHA
    a395faf View commit details
    Browse the repository at this point in the history

  10. First draft for variable declarations

    @lukastaegert
    lukastaegert committed Feb 11, 2018
    Configuration menu
    Copy the full SHA
    de9acd0 View commit details
    Browse the repository at this point in the history

  11. * Simplify declaration rendering logic 

    * Move responsibility to suppress semicolon to parent
    @lukastaegert
    lukastaegert committed Feb 11, 2018
    Configuration menu
    Copy the full SHA
    ed77a00 View commit details
    Browse the repository at this point in the history

  12. Prevent trailing white-space

    @lukastaegert
    lukastaegert committed Feb 11, 2018
    Configuration menu
    Copy the full SHA
    d2720f6 View commit details
    Browse the repository at this point in the history

  13. Remove line-breaks after declaration key-word

    @lukastaegert
    lukastaegert committed Feb 11, 2018
    Configuration menu
    Copy the full SHA
    6bb3829 View commit details
    Browse the repository at this point in the history

  14. Resolve #1937

    @lukastaegert
    lukastaegert committed Feb 11, 2018
    Configuration menu
    Copy the full SHA
    2a570a2 View commit details
    Browse the repository at this point in the history

  15. Resolve #1831

    @lukastaegert
    lukastaegert committed Feb 11, 2018
    Configuration menu
    Copy the full SHA
    3588a4a View commit details
    Browse the repository at this point in the history

  16. Resolve #1943

    @lukastaegert
    lukastaegert committed Feb 11, 2018
    Configuration menu
    Copy the full SHA
    9ff220f View commit details
    Browse the repository at this point in the history

  17. Include line-breaks with the previous statement instead of the 

    next—even though it can produce less nice code—as otherwise, it was not
guaranteed each single line comment was properly closed
    @lukastaegert
    lukastaegert committed Feb 11, 2018
    Configuration menu
    Copy the full SHA
    6b30972 View commit details
    Browse the repository at this point in the history

  18. Rework declaration handling to associate comments after a comma but 

    before a line-break with the previous declarator
    @lukastaegert
    lukastaegert committed Feb 11, 2018
    Configuration menu
    Copy the full SHA
    103e16f View commit details
    Browse the repository at this point in the history

  19. Fix TypeScript test

    @lukastaegert
    lukastaegert committed Feb 11, 2018
    Configuration menu
    Copy the full SHA
    377fe90 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2018

  1. * Improve some names 

    * Get rid of unnecessary defaults
* Replace tilde operator
    @lukastaegert
    lukastaegert committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    495f97a View commit details
    Browse the repository at this point in the history

  2. * Reintroduce statement concept as an alias 

    * Rename noSemicolon -> isStatement
    @lukastaegert
    lukastaegert committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    acaea3d View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2018

  1. Reduce number of necessary slices by supplying start indices

    @lukastaegert
    lukastaegert committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    d45a74c View commit details
    Browse the repository at this point in the history

  2. Only calculate boundaries if necessary

    @lukastaegert
    lukastaegert committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    adeebc2 View commit details
    Browse the repository at this point in the history

  3. Store flags for AST nodes directly on the prototype

    @lukastaegert
    lukastaegert committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    8ecadf2 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2018

  1. Improve variable declaration performance

    @lukastaegert
    lukastaegert committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    114149f View commit details
    Browse the repository at this point in the history

  2. * Use charCodeAt where possible to improve performance 

    * Properly handle \r\n line-breaks
    @lukastaegert
    lukastaegert committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    22aa1fb View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2018

  1. Slightly clean up source map removal

    @lukastaegert
    lukastaegert committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    bb8b81d View commit details
    Browse the repository at this point in the history