Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reexport namespace deshadow #1960

Merged
merged 2 commits into from
Feb 15, 2018
Merged

Reexport namespace deshadow #1960

merged 2 commits into from
Feb 15, 2018

Conversation

guybedford
Copy link
Contributor

@guybedford guybedford commented Feb 10, 2018 •
edited
Loading

This fixes #1338 ensuring namespace exports which are in turn reexported are properly traced during deshadowing.

@guybedford guybedford mentioned this pull request Feb 10, 2018
Closed
lukastaegert
lukastaegert approved these changes Feb 12, 2018
View reviewed changes
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukastaegert lukastaegert added this to the 0.56.0 milestone Feb 12, 2018
@lukastaegert lukastaegert merged commit acc8927 into master Feb 15, 2018
@lukastaegert lukastaegert deleted the reexport-namespace-deshadow branch February 15, 2018 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.56.0
Development

Successfully merging this pull request may close these issues.

Scoped variable name conflict with star import
2 participants
@guybedford @lukastaegert