-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few performance improvements #2052
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Even though it may only be a moderate improvement overall, sourcemap generation is now around 45% faster while your changes to the loops alone improved tree-shaking performance by 25%. I hope to find some time soon to tackle the proto issue soon but this is really moving us forward in a great direction!
@guybedford I assume there is no objection from your side if I put this into the next release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see this!
A few minor optimizations:
sourcemap-codec
to an optimized version (see Massive performance improvements Rich-Harris/sourcemap-codec#71)With this PR, Mapbox GL JS bundle is about 10-12% faster (from 9.5s to 8.5s).