Print --perf timings in --watch mode #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/utils/timers.ts
Outdated
| ) | ||
| .forEach(label => { | ||
| newTimings[label] = timers[label].time; | ||
| }); |
There was a problem hiding this comment.
Did this sorting ever change anything for you? As the entries are added to timers as soon as timeStart is called for the first time and Object.keys implicitly iterates keys in the order they are added, I do not think tracking start times or sorting the entries should be necessary. Or am I overlooking something here which is relevant for watch mode?
There was a problem hiding this comment.
@lukastaegert whoops, you're right -- sorry, I'd intended to revert this before pushing but forgot. Fixed now!
anandthakker
force-pushed
the
print-watch-timings
branch
from
b1b517d
to
6913e39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also sorts the timing output by start time